Jump to content

DOWNLOAD MODS

Are you looking for something shiny for your load order? We have many exclusive mods and resources you won't find anywhere else. Start your search now...

LEARN MODDING

Ready to try your hand at making your own mod creations? Visit the Enclave, the original ES/FO modding school, and learn the tricks of the trade from veteran modders...

JOIN THE ALLIANCE

Membership is free and registering unlocks image galleries, project hosting, live chat, unlimited downloads, & more...

Disease Mod

Dane

By Dane
in Scripting

 Share

Recommended Posts

Dane Disciple

Dane

Posted
Posted (edited)

im making a disease mod as most of you know but i cant get this 

scn DZFMidCureDisease

short GetRandI

begin Scripteffectstart

	set GetRandI to (player.getav Restoration + player.getav Intelligence) / 20

end


Begin ScriptEffectupdate

	if player.getitemcount MandrakeRoot 20 && player.getitemcount ElfCupCap 20 && player.getitemcount NightShade 5

		player.removeitemNS MandrakeRoot 20 

		player.RemoveitemNS ElfCupCap 20

		player.removeitemNS nightshade 5

	else

		Message "Get the items to try to cure yourself"

		Return

	endif

end


Begin ScriptEffectfinish

	if getRandI <= 1

		if GetRandompercent <= 15

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 15 && Getrandompercent <= 25

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 25

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

	Elseif GetRandI > 1 && GetRandI <= 2

		if GetRandompercent <= 20

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 20 && Getrandompercent <= 30

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 30

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

	Elseif GetrandI > 2 && GetRandI <= 3

		if GetRandompercent <= 25

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 25 && Getrandompercent <= 35

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 35

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

	Elseif GetrandI > 3 && GetRandI <= 4

		if GetRandompercent <= 30

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 30 && Getrandompercent <= 40

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 40

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

	Else

		if GetRandompercent <= 35

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 35 && Getrandompercent <= 45

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 45

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	endif

end

to work :trophy: if some could take a look at it i would be really glad.

(i get a mismatched Begin/end block error, and a mismatched If/then/else erorr)

Edited by DaneZ
Link to comment
Share on other sites
WillieSea Blade Master

WillieSea

Posted
Posted 

scn DZFMidCureDisease

short GetRandI

begin Scripteffectstart

	set GetRandI to (player.getav Restoration + player.getav Intelligence) / 20


	if ( player.getitemcount MandrakeRoot >= 20 ) && ( player.getitemcount ElfCupCap >= 20 ) && ( player.getitemcount NightShade >= 5 )

		player.removeitemNS MandrakeRoot 20 

		player.RemoveitemNS ElfCupCap 20

		player.removeitemNS nightshade 5

	else

		Message "Get the items to try to cure yourself"

		Return

	endif

end


Begin ScriptEffectfinish

	if getRandI <= 1

		if GetRandompercent <= 15

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 15 && Getrandompercent <= 25

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 25

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	Elseif GetRandI > 1 && GetRandI <= 2

		if GetRandompercent <= 20

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 20 && Getrandompercent <= 30

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 30

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	Elseif GetrandI > 2 && GetRandI <= 3

		if GetRandompercent <= 25

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 25 && Getrandompercent <= 35

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 35

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	Elseif GetrandI > 3 && GetRandI <= 4

		if GetRandompercent <= 30

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 30 && Getrandompercent <= 40

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 40

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	Else

		if GetRandompercent <= 35

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		elseif Getrandompercent > 35 && Getrandompercent <= 45

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		elseif Getrandompercent > 45

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		endif

	endif

end[/code]



I put some fixes in the code above.

What does it do or not do?
Link to comment
Share on other sites
Dane Disciple

Dane

Posted
  • Author
Posted (edited)

it should check your intelligence and Restoration and cure all your diseases if your lucky (higher chance = higher intelligence/restoration)

EDIT: :trophy: it works (gives no errors in CS)

Edited by DaneZ
Link to comment
Share on other sites
WillieSea Blade Master

WillieSea

Posted
Posted

I totally rewrote your script to make it more effecient.

1. I reversed all your if conditions to check for the highest number first. That way you do not have to check for the 'less than' condition.

2. Got rid of the multiple GetRandomPercent functions and added a new variable that will store the number for reuse..

3. There was no need for the ScriptEffectUpdate block of code since it only needs to run once. Otherwise every frame it ran it would try to remove the ingredients from the player.

scn DZFMidCureDisease

short GetRandI

short myNumber


begin Scripteffectstart

	set GetRandI to (player.getav Restoration + player.getav Intelligence) / 20


	if ( player.getitemcount MandrakeRoot >= 20 ) && ( player.getitemcount ElfCupCap >= 20 ) && ( player.getitemcount NightShade >= 5 )

		player.removeitemNS MandrakeRoot 20 

		player.RemoveitemNS ElfCupCap 20

		player.removeitemNS nightshade 5

	else

		Message "Get the items to try to cure yourself"

		Return

	endif

end


Begin ScriptEffectfinish

	set myNumber to GetRandomPercent


	If GetrandI > 4

		If myNumber > 45

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		elseif myNumber > 35

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		else

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		endif

	Elseif GetrandI > 3

		If myNumber > 40

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		elseif myNumber > 30

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		else

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		endif

	Elseif GetrandI > 2

		If myNumber > 35

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		elseif myNumber > 25

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		else

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		endif

	Elseif GetRandI > 1

		If myNumber > 30

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		elseif myNumber > 20

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		else

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		endif

	Elseif getRandI <= 1

		If myNumber > 25

			Player.addspellNS DZFAILCURE

			message "You failed to cure yourself, you feel worse"

			Return

		elseif myNumber > 15

			player.addspellNS DZCUREDISEASES2

			message "You succeeded to cure yourself, but it did have side-effects"

			Return

		else

			Player.addspellNS DZCUREDISEASES

			Message "You succeeded to cure yourself"

			Return

		endif

	endif

end[/code]
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...